Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

g++ warning fixes #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

g++ warning fixes #9

wants to merge 2 commits into from

Conversation

dfries
Copy link

@dfries dfries commented Oct 11, 2015

Fixed comment typos and macro #if tests that g++ was complaining about, it complains if SOMETHING isn't defined such as '#if SOMETHING'

v-usb has been working on my project and I haven't had any USB problems.

dfries added 2 commits October 11, 2015 15:35
@dfries
comment typos
e5b5629
@dfries
fix avr-g++ 4.7.2 warnings add missing macro defined check
329d77e 
warning: "__CODEVISIONAVR__" is not defined
Check to see if it is defined, instead of using the value of a
potentially undefined definition.
@lod lod mentioned this pull request Oct 21, 2016
Merged
@starkjohann
Copy link
Contributor

I don't want to merge the warning fix as is, because the documentation for USB_CFG_HID_REPORT_DESCRIPTOR_LENGTH states "Otherwise don't define it or define it to 0". The #if defined would count 0 as defined, too.

Would the warning go away if we put an extern "C" around the entire header, not just the includes at the top?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dfries @starkjohann